search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Fix YAML dump/load issues with SqlLiteral node. #503

Closed bobf closed 6 years ago

bobf commented 6 years ago

Resolves issue demonstrated below:

require 'psych'
require 'arel'
yaml = Arel::Nodes::SqlLiteral.new('*').to_yaml
puts Psych.load(yaml).is_a?(Arel::Nodes::SqlLiteral) # false

When deserializing an Arel query containing a SqlLiteral node, Arel breaks as it expects a Node, but instead gets a String, preventing the query from being loaded.

Note that I only delegated String methods that are covered by tests - interested in feedback on how much of the String contract should be implemented for cases where users are expecting the object to quack like a String (and open to suggestions for how to address this).

rails-bot commented 6 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @tenderlove (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

matthewd commented 6 years ago

Per #523, Arel development is moving to rails/rails.

If this PR is still relevant, please consider reopening it over there.