search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Explicitly mentions the #and operator #511

Closed ecbrodie closed 6 years ago

ecbrodie commented 6 years ago

This PR adds explicit documentation for the .and operator in AREL. It is true that it was already included existing documentation ("behaves similarly" to .or), but wasn't explicit enough when I was searching the README (via CMD-F) for an example of a call to .and.

I ended up learning about the existence of .and through this blog post. I would have preferred to intake this code example through the official README instead. Hopefully this PR will allow future developers using AREL to do so.

By the way, I also moved documentation about DISTINCT to its own paragraph. It seems more appropriate to be separate from OR and AND documentation.

rails-bot commented 6 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @tenderlove (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.