rails / arel

A Relational Algebra

2.06k stars 390 forks source link

CI with Ruby 2.5.0 #516

Closed yahonda closed 6 years ago

yahonda commented 6 years ago

This pull request adds CI with Ruby 2.5.0. It would fail with Ruby 2.5.0 and ruby-head due to NameError: uninitialized constant FakeRecord::Connection::DateTime I'll open another issue for this error.

Updated: NameError: uninitialized constant FakeRecord::Connection::DateTime has been addressed in this pull request.

rails-bot commented 6 years ago

r? @tenderlove

(@rails-bot has picked a reviewer for you, use r? to override)

yahonda commented 6 years ago

517 is a blocker for this pull request.

yahonda commented 6 years ago

Addressed #517 by https://github.com/rails/arel/pull/516/commits/f4477d631f19e7a9e09f77062a0992121d0bca16 Now builds are green.