search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Allow NamedFunction as the right side of Assignment #522

Closed md5 closed 6 years ago

md5 commented 6 years ago

This PR enhances the Assignment node to allow a NamedFunction on the right side. This allows the UpdateManager to construct queries like UPDATE my_table SET my_column = TRIM(my_column), which we wanted to do for a dynamic query in a migration recently.

rails-bot commented 6 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

md5 commented 6 years ago

@sgrif Any interest in this PR?

matthewd commented 6 years ago

Per #523, Arel development is moving to rails/rails.

If this PR is still relevant, please consider reopening it over there.