search

rails / arel

A Relational Algebra
2.06k stars 390 forks source link

Remove math module from count #525

Closed nikolai-b closed 6 years ago

nikolai-b commented 6 years ago

Not required after #449 has been merged. There is still a spec https://github.com/rails/arel/blob/master/test/nodes/test_count.rb#L35-L41 to show it isn't needed.

Following on from https://github.com/rails/arel/pull/455#issuecomment-371210858

rails-bot commented 6 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

matthewd commented 6 years ago

Per #523, Arel development is moving to rails/rails.

If this PR is still relevant, please consider reopening it over there.