Closed junaruga closed 7 years ago
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
https://travis-ci.org/rails/coffee-rails/builds/223699250 Ruby 2.4.1 with Gemfile-4-0-stable and 4-1-stable were failed due to core dump.
@rafaelfranca is it possible to add those Ruby 2.4.1's failed cases to allow_failures?
rbx-2
were also failed due to below situation.
I know that rbx
, rbx-3
and rbx-3.74
are also failed for same situation.
So, I will add rbx-2
to allow_failures
right now.
Requested binary installation but no rubies are available to download, consider skipping --binary flag.
Yeah, we can exclude 2.4 from 4.0 and 4.1 tests
@rafaelfranca ok. I updated, and did rebase on your way right now. However I got an another error. and failed for all the rubies.
TemplateHandlerTest#test_coffee_views_are_served_as_javascript:
NameError: uninitialized constant ActionView::DependencyTracker
Ah just moment. I will try my PR on latest master branch
Ah no. Same result..
Finally all the test was passed on this PR, after your fixing https://github.com/rails/coffee-rails/issues/93#issuecomment-299579281 . Thanks.
@rafaelfranca - LGTM
Hi there !
Rubinius won't be installed on a default Travis build (which is running on Precise). Could you try to set dist: trusty
in the Travis configuration file please ?
@robin850 ok thanks for the information. Let me try it.
@robin850 Do you have both rbx-2
and rbx-3
test environment? or for only rbx-3
?
@junaruga : Thanks for the quick update and upgrade of Rubinius ; testing against version 3 is fine ! :-)
Oh and actually I guess tests will never pass under 4.1 and 4.2, could you only test against 5-0-stable and the current Gemfile for Rubinius please ? 😊
@robin850 ok. So maybe current commit is fine for you.
rbx
was installed on dist: trusty
.
However 2 rbx
environments of the total 3, the rbx
with Rails 4.1 and 4.2 stable are failed for core-dump.
https://travis-ci.org/rails/coffee-rails/builds/229458994
So, I think that adding rbx-3
as allow_failures is good idea.
@robin850
Oh and actually I guess tests will never pass under 4.1 and 4.2, could you only test against 5-0-stable and the current Gemfile for Rubinius please ? 😊
oh okay. just moment.
The rbx-3
's situation is that it passed the tests for 4.0, 4.1, 4.2, 5.0, Gemfile
.
But on last build, it passed 4.1, 4.2 tests themselves, but it was finished with error because of core dump.
So, I like to add rbx-3
to allow_failures.
5 runs, 12 assertions, 0 failures, 0 errors, 0 skips
Segmentation fault (core dumped)
@robin850 is it fine for you for my current commit?
Yeah yeah, it's perfect. I will let @rafaelfranca merge this, thanks !
I updated Rubies to latest version. I also added ruby-head to Travis as allow_failures.
I think this is useful. Because we can prepare before next version Ruby 2.5 release. We can see this kind of logic in
rails/rails
,rspec
andcucumber
and etc too.https://github.com/rails/rails/blob/master/.travis.yml https://github.com/rspec/rspec-core/blob/master/.travis.yml https://github.com/cucumber/cucumber-ruby/blob/master/.travis.yml
Is it possible to merge?
Thanks.