rails / cssbundling-rails

Bundle and process CSS in Rails with Tailwind, PostCSS, and Sass via Node.js.
MIT License
563 stars 83 forks source link

Synchronize bin/dev from jsbundling-rails to cssbundling-rails #151

Closed dorianmarie closed 5 months ago

dorianmarie commented 5 months ago

There are different bin/dev being generated by cssbundling-rails and jsbundling-rails

See https://github.com/rails/jsbundling-rails/pull/174

dev: Use an affirmative conditional

...and avoid regex in match.

(Try a gem list ails vs a gem list --exact ails to see what I mean.)

dorianmarie commented 5 months ago

Here is what I was getting:

Add bin/dev to start foreman
    conflict  bin/dev
Overwrite /Users/dorianmariefr/src/traffic-jam/bin/dev? (enter "h" for help) [Ynaqdhm] d
  #!/usr/bin/env sh

- if ! gem list foreman -i --silent; then
+ if gem list --no-installed --exact --silent foreman; then
    echo "Installing foreman..."
    gem install foreman
  fi

  # Default to port 3000 if not specified
  export PORT="${PORT:-3000}"

  exec foreman start -f Procfile.dev "$@"
Retrying...
Overwrite /Users/dorianmariefr/src/traffic-jam/bin/dev? (enter "h" for help) [Ynaqdhm] 

cc: @dhh

dorianmariecom commented 5 months ago

@dhh could you release a new version please?

dhh commented 5 months ago

Done.

dorianmarie commented 5 months ago

Thanks @dhh you dat best :)

dorianmarie commented 5 months ago

See you at RailsConf?