search

rails / dartsass-rails

Integrate Dart Sass with the asset pipeline in Rails
MIT License
211 stars 42 forks source link

Use array args instead of string args for system command #45

Closed ntkme closed 9 months ago

ntkme commented 1 year ago

This PR has the following changes:

  1. Replace the string command with array command to avoid spawning a subshell before execute the child process. This also remove the need of escaping command and arguments, because the array form is treated literally.
  2. Add ruby interpreter to run ruby script, so that it works on windows where shebang is not supported.
ntkme commented 9 months ago

@dhh I have added some comments explaining the changes here. Would you mind take a look when you get a chance? Thanks.

dhh commented 9 months ago

Looks good!