search

rails / devcontainer

MIT License
48 stars 14 forks source link

Consider adding `rbenv init` to global shell configurations #50

Closed jarrodldavis closed 3 days ago

jarrodldavis commented 1 week ago

I use the dotfiles personalization support of VSCode's development containers extension to copy over, among other configs, a custom .zshrc.

Unfortunately, the ruby feature has already customized the ~/.zshrc that is present in the base dev container image:

https://github.com/rails/devcontainer/blob/916aec13c12ab57d0f9b42b84797912942fc2ea9/features/ruby/install.sh#L23-L27

This causes the ruby command to not be found, and thus the postCreateCommand in the default Rails dev container configuration to not work:

https://github.com/rails/rails/blob/13d5f87208921cc5139cd53b280c42f23c334826/railties/lib/rails/generators/rails/devcontainer/templates/devcontainer/devcontainer.json.tt#L36

I think it would be better to either append to the global shell configurations (/etc/bash.bashrc and /etc/zsh/zshrc) or find the appropriate lifecycle hook to append to the user-specific configurations after dotfiles have been copied over.

jarrodldavis commented 3 days ago

Thankfully, I've figured out a way around this issue (and the general issue of clobbering automatically-managed shell configurations) by using ZDOTDIR in ~/.zshenv, so this is less pressing of an issue to me now.