Improve `Encoding` handling

rails / execjs

Run JavaScript code from Ruby

MIT License

538 stars 282 forks source link

Improve `Encoding` handling #111

Closed casperisfine closed 2 years ago

casperisfine commented 2 years ago

Comparing the Encoding instance directly is more efficient.

Also ASCII-8BIT may be renamed in 3.2: https://bugs.ruby-lang.org/issues/18576

matthewd commented 2 years ago

The mentioned JRuby bug was fixed 10 years ago... this project is very stable, so may not be worth the bother, but seems like this module could just go away.

byroot commented 2 years ago

Indeed 🤦