Remove timestamps from generated partial

rails / jbuilder

Jbuilder: generate JSON objects with a Builder-style DSL

MIT License

4.34k stars 440 forks source link

Remove timestamps from generated partial #448

Closed robin850 closed 5 years ago

robin850 commented 6 years ago

Hello,

This pull request fixes #437.

When the --no-timestamps option is passed to the scaffold generator, Active Record will properly remove the created_at and updated_at columns from the migration file but the generated Jbuilder partial will still reference these fields.

Have a nice day !

rails-bot commented 6 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (NB. this repo may be misconfigured) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

olleolleolle commented 5 years ago

@robin850 Oh, this looks super-clear - and fixes the issue.