search

rails / jbuilder

Jbuilder: generate JSON objects with a Builder-style DSL
MIT License
4.34k stars 440 forks source link

Run Railtie from the tests so that we can detect bugs inside Railtie #556

Closed amatsuda closed 10 months ago

amatsuda commented 11 months ago

552 seems like a valid fix. The require statement seems to be requiring something that no longer exists. Then why isn't the CI failing? It should be because the Jbuilder Railtie is not executed during the tests.

So, here's an attempt to make the CI run the Railtie. Let's see if the CI properly fails now...

amatsuda commented 10 months ago

Confirmed that tests were failing with this patch https://github.com/rails/jbuilder/actions/runs/7401605179, then merged #552 and rebased, and all the tests are passing now 🎉