Closed bogdan closed 12 years ago
Remove unnecessary gsub call.
gsub
Originally this gsub call appeared as "for performance" hack. But unfortunattely having it right there doesn't fix some problems described here: https://github.com/rails/journey/commit/8317cde20b0805c30e1ff2a879a9b8ba948cfa76
Now, we can remove it.
Also removed test that asserts some internal behavior of the formatter that doesn't have a use case in actionpack: it tests behavior of formatter when it doens't have all required parameters, but this case is filtered at verify_required_parts!.
verify_required_parts!
Remove unnecessary
gsubcall.Originally this
gsubcall appeared as "for performance" hack. But unfortunattely having it right there doesn't fix some problems described here: https://github.com/rails/journey/commit/8317cde20b0805c30e1ff2a879a9b8ba948cfa76Now, we can remove it.
Also removed test that asserts some internal behavior of the formatter that doesn't have a use case in actionpack: it tests behavior of formatter when it doens't have all required parameters, but this case is filtered at
verify_required_parts!.