Fix Tests

[schneems]

Pattern.new(strexp) now returns an object that does not 'match' correctly. Relying on the method Pattern#match instead to verify if a given pattern is valid.

152 tests, 326 assertions, 0 failures, 0 errors, 0 skips

[pixeltrix]

@schneems how are these tests failing for you? The tests on Travis are green and testing locally appears to work - do you have an example failure?

[schneems]

Sorry, forgot to run bundle exec while running tests so be rake works but just plain rake was giving me errors

  1) Error:
test_to_regexp_with_group(Journey::Path::TestPattern):
TypeError: can't convert Journey::Path::Pattern to String
    /Users/schneems/Documents/projects/tmp/journey/test/path/test_pattern.rb:122:in `test_to_regexp_with_group'

  2) Error:
test_insensitive_regexp_with_group(Journey::Path::TestPattern):
TypeError: can't convert Journey::Path::Pattern to String
    /Users/schneems/Documents/projects/tmp/journey/test/path/test_pattern.rb:189:in `test_insensitive_regexp_with_group'

  3) Error:
test_to_regexp_match_non_optional(Journey::Path::TestPattern):
TypeError: can't convert Journey::Path::Pattern to String
    /Users/schneems/Documents/projects/tmp/journey/test/path/test_pattern.rb:111:in `test_to_regexp_match_non_optional'

  4) Error:
test_to_regexp_with_extended_group(Journey::Path::TestPattern):
TypeError: can't convert Journey::Path::Pattern to String
    /Users/schneems/Documents/projects/tmp/journey/test/path/test_pattern.rb:88:in `test_to_regexp_with_extended_group'

Closing this issue.

[pixeltrix]

That'll be the old Minitest bundled with 1.9 causing the problem - previously assert_match checked to see if the actual value was a String.