search

rails / journey

A router for rails
221 stars 57 forks source link

Please deprecate Journey #68

Closed voxik closed 10 years ago

voxik commented 10 years ago

Based on #49, it seems that journey was deprecated. Could you please add the notice somewhere? The thing is that this might be issue for Fedora, since Fedora prohibits bundling and Journey used to be independent gem. Hence I should unbundle Journey again, but that would make no sense.

Thanks

rafaelfranca commented 10 years ago

I don't think we need any notice. Who want to use this gem is free, it is still valid.

What was integrated in Rails is already another code base.

markrebec commented 10 years ago

I'm kind of curious about this as well - I've got a project that uses Journey in rails 3.2, but uses the built-in ActionDispatch::Journey in rails 4.

For reference here is the gem - https://github.com/markrebec/excursion - which provides cross-application route sharing through a shared route pool. I was excited to potentially decouple the gem from rails to make it a bit more generic so it could be used in sinatra and other smaller projects/frameworks.

Part of that was the idea that I might be able to depend directly on Journey for all the internal route handling within excursion, but now that it's been coupled with rails 4 and this gem has been deprecated, that doesn't seem realistic.

You say the gem is still valid, however I assume it's not going to be maintained nor kept up along with it's counterpart in rails 4+. Can you confirm whether that is the case or not? I'd also assume that if a project like excursion was trying to depend directly on Journey, there may be some issues/conflicts when using the gem with rails 4 (even though the classes in rails 4 are namespaced under ActionDispatch)

Given my assumed answers for the questions above, it sounds to me like it would definitely be worth it to add a notice to the readme. I think it's at least worth mentioning that the project has been merged with rails and this repo is no longer being maintained (if that's indeed the case).

rafaelfranca commented 10 years ago

Yes. This is indeed the case. But for people using a Rails 3.2 application this project is still maintained for security patches. So this gem is not deprecated, it is only part of Rails 4 now.

markrebec commented 10 years ago

OK, that's a good point, and fair enough. I hadn't thought about the fact that Rails 3.2 is still a relatively current version, is widely used by the public, and (obviously) still depends on this standalone version of Journey, which means technically this project isn't ready to be deprecated yet.

Thanks for the feedback, I can definitely see where you're coming from.

I would personally still push for a readme note mentioning that the project has been merged into rails as of rails 4+, but that's obviously your call! :smile:

rafaelfranca commented 10 years ago

Agree about the note. Just did it.

voxik commented 10 years ago

@rafaelfranca Thanks for the note.