search

rails / jquery-rails

A gem to automate using jQuery with Rails
MIT License
948 stars 406 forks source link

jQuery 3.0.0 has been released #223

Closed connorshea closed 8 years ago

connorshea commented 8 years ago

http://blog.jquery.com/2016/06/09/jquery-3-0-final-released/

Sega100500 commented 8 years ago

Please upgrade gem to use jQuery 3

//= require jquery3

will be FINE

bodrovis commented 8 years ago

Btw, note that now a "slim" version of jQuery is also available:

All in all, it excludes ajax, effects, and currently deprecated code. The size of jQuery is very rarely a load performance concern these days, but the slim build is about 6k gzipped bytes smaller than the regular version – 23.6k vs 30k

cannikin commented 8 years ago

Well, I added 3.0.0 and was about to create a pull request, but I read the contribution guidelines and for security reasons they can't accept pull requests that include new versions of the JS files. But, if anyone needs to use 3.0.0 in an emergency (and trusts me!) you can get my version here: https://github.com/cannikin/jquery-rails and use the jquery-3 branch.

bodrovis commented 8 years ago

@cannikin :cool:

connorshea commented 8 years ago

@cannikin you can probably open an MR with the scaffolding, and then they can merge it and add the actual jQuery library itself.

cannikin commented 8 years ago

@connorshea Oooo, good call. I'll make one with empty JS files and they can copy/paste the actual code in there whenever someone gets the chance.

cannikin commented 8 years ago

Done! #224

ghost commented 8 years ago

Is there anything I can do to help get #224 merged in?

Sega100500 commented 8 years ago

When support for jQuery 3 will be added to official release of jquery-rails gem ?

connorshea commented 8 years ago

@rafaelfranca sorry to bother you, but could you check this out or assign a core member to it?

(Thank you for maintaining Rails over the past few years, you've been awesome ❤️)

rafaelfranca commented 8 years ago

No problem! I just commented in the PR. Let's get it merged 👍

Sega100500 commented 8 years ago

@rafaelfranca gem update , bundle update has no effect In Gemfile.lock still jquery-rails (4.1.1) Please update in global repository