search

rails / jquery-rails

A gem to automate using jQuery with Rails
MIT License
948 stars 406 forks source link

Add possibility to test HTML attribute selectors #236

Closed mrhead closed 7 years ago

mrhead commented 7 years ago

Previously it wasn't possible to test something like this:

assert_select_jquery :remove, "[data-placeholder~=name]"

This commit fixes it by escaping [ and ] characters in the selector.

rails-bot commented 7 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

mrhead commented 7 years ago

Tests are failing on ruby-head because of gem installation error. Can it be ignored?