search

rails / jquery-ujs

Ruby on Rails unobtrusive scripting adapter for jQuery
MIT License
2.61k stars 508 forks source link

$.rails undefined with jquery 3.4.0 #515

Open phoet opened 5 years ago

phoet commented 5 years ago

our automated @depfu yarn updates had some errors in our system-tests.

with jquery 3.4.0 there are some problems with jquery-ujs and other libraries such as bootstrap-datepicker.

i'm not completely sure what is happening there. just leaving this here in case anyone else finds related issues.

phoet commented 5 years ago

it looks like this is because of https://github.com/yarnpkg/yarn/issues/4125

it looks like it got fixed here, but i assume no new version has been released to NPM?

Screen Shot 2019-04-23 at 16 01 35

phoet commented 5 years ago

@theflow 👀 i guess that there will be many issues that like that with your js builds

phoet commented 5 years ago

@rafaelfranca could you take a look and verify that this will need a new npm release? thx!

phoet commented 5 years ago

@lucasmazza do you know who can be asked about releasing a new npm version of this?

phoet commented 5 years ago

😿

lucasmazza commented 5 years ago

☝️ ping @rafaelfranca

klaustopher commented 4 years ago

@phoet hitting the same issue, have you found any workarounds?

phoet commented 4 years ago

@klaustopher editing the yarn.lock by hand...

klaustopher commented 4 years ago

Hmm, ok .. I'd like to run the jquery update but if this is not possible, then we might need to always stay on 3.3.x ☹️

phoet commented 4 years ago

It is possible, just yarn thinks it should use different versions for your dependencies. If you update and them merge both dependencies in your yarn.lock everything works fine.