rails / jsbundling-rails

Bundle and transpile JavaScript in Rails with esbuild, rollup.js, or Webpack.
MIT License
831 stars 143 forks source link

Default to port 3000 while allowing override #148

Closed elia closed 1 year ago

elia commented 1 year ago

With this configuration bin/dev will use port 3000, but bin/dev -p 3001 will correctly start the server on port 3001.

dhh commented 1 year ago

This would overwrite the port ENV set by a Dockerfile, so don't think that works.

elia commented 1 year ago

@dhh updated so it respects a PORT environment variable set from outside

dhh commented 1 year ago

could you do the same on cssbundling-rails? thanks

elia commented 1 year ago

@dhh sure! Here it is https://github.com/rails/cssbundling-rails/pull/124