search

rails / jsbundling-rails

Bundle and transpile JavaScript in Rails with esbuild, rollup.js, or Webpack.
MIT License
831 stars 143 forks source link

Test installer commands (retry) #197

Closed jonathanhefner closed 1 month ago

jonathanhefner commented 1 month ago

This is a retry of #182. I have added a gemfile for Rails 6.1, and refreshed all gemfile lock files.

@dhh I did not track down the root cause of the messages in https://github.com/rails/jsbundling-rails/pull/196#issue-2436103482, but they only appear when testing with Rails 6.0. Currently, main branch tests with Rail 6.1 by default. In #182, I had changed that to Rails 6.0 to match the gemspec, but I have changed it back to Rails 6.1 in this PR.

In summary, after this PR is merged: the gemspec will require Rails >= 6.0, bundle exec rake will test with Rails 6.1, and CI will test with Rails >= 6.1.

dhh commented 1 month ago

That worked!

dhh commented 1 month ago

Could you add a bin/test binstub as well to trigger this? And maybe we should also get some github hooks setup to run automatically on PRs.

jonathanhefner commented 1 month ago

@dhh

Could you add a bin/test binstub as well to trigger this?

Do you mean a binstub to run bundle exec rake with just the default Gemfile, or once for each gemfile? I've submitted #198 to do the latter, but I can strip out the loop if you prefer.

And maybe we should also get some github hooks setup to run automatically on PRs.

The GitHub workflow from this PR will trigger on PRs:

https://github.com/rails/jsbundling-rails/blob/2413e21cd6d6c42bbaad1d3275b50faac63707ba/.github/workflows/ci.yml#L2

Or did you mean something else?

dhh commented 1 month ago

Was thinking that bin/test should run everything.

Ahh, hadn't noticed that on the ci.yml. All good then.