search

rails / marcel

Find the mime type of files, examining file, filename and declared type
Apache License 2.0
386 stars 67 forks source link

Replace mimemagic with ruby-magic #26

Closed georgeclaghorn closed 3 years ago

AFU92 commented 3 years ago

Fix:

https://github.com/rails/rails/issues/41750

ssunday commented 3 years ago

Is the intent still to remove mimemagic from marcel now that mimemagic 0.3.7 has been released under MIT https://rubygems.org/gems/mimemagic/versions/0.3.7?

krtschmr commented 3 years ago

I would say that it's not ideal to do it during runtime and believe the rails-core wants a more robust solution

ssunday commented 3 years ago

I would say that it's not ideal to do it during runtime and believe the rails-core wants a more robust solution

Agreed! I would prefer this replacement.

georgeclaghorn commented 3 years ago

Closing in favor of #30.