rails / marcel

Find the mime type of files, examining file, filename and declared type
Apache License 2.0
386 stars 67 forks source link

Update dependency on mimemagic gem #29

Closed adam-ludgate closed 3 years ago

adam-ludgate commented 3 years ago

Acceptable solution? Without knowing the details of the dependency on the mimemagic gem, hoping this will solve build issues for Rails 5.2.x

ssunday commented 3 years ago

@adam-ludgate see https://github.com/rails/marcel/pull/26 — another solution in the works by Rails team, hopefully merged in soon and will fix all Rails versions 5.2+.

matthewd commented 3 years ago

Yeah, this doesn't change the set of versions allowed by that selector. If ~> 0.3.2 is currently failing to find any versions for you, my blind guess would be that it's to do with extra requirements of the 0.3.7 release (most likely the nokogiri dep); I don't see any way a release with this diff would help that.