rails / mission_control-jobs

Dashboard and Active Job extensions to operate and troubleshoot background jobs
MIT License
611 stars 71 forks source link

Workers filters #115

Open Xeitor opened 7 months ago

Xeitor commented 7 months ago

Pending

Closes: #29

Xeitor commented 7 months ago

hey @rosa, hope you are doing great, when you have some time, I would like to hear your thoughts about the configuration/queues filter

I was thinking about making some kind of dynamic form so the user can input many key/value pair of attributes

Xeitor commented 7 months ago

update: i was checking the solid_queue codebase and seems like workers metadata field can only have polling_interval, queues and thread_pool_size, if that is the case we could add the three of them as different inputs for now

rosa commented 5 months ago

@Xeitor, I'm so sorry for the huge delay on this one 😳 I've been so busy with other stuff that I had to leave this gem quite unattended for a while, but I'm going to catch up this week.

i was checking the solid_queue codebase and seems like workers metadata field can only have polling_interval, queues and thread_pool_size, if that is the case we could add the three of them as different inputs for now

I think I'd like to keep this as generic as possible, so that we can also build support for resque and other backends easily. I think the only field that makes sense to filter by there is queues.

Xeitor commented 5 months ago

@rosa no worries!! I guessed you were busy so no problem really :)

Xeitor commented 5 months ago

@rosa I've just realized the queues filter is a little trickier than I thought

because the metadata is a text attr, we'll not be able to query it from the db, instead we'll have to perform the filter in memory, but I'll need to modify the enumerable logic similar to JobsRelation#perform_each