search

rails / mission_control-jobs

Dashboard and Active Job extensions to operate and troubleshoot background jobs
MIT License
611 stars 71 forks source link

Relax dependency for Rails 8 #138

Closed dorianmariecom closed 3 months ago

dorianmariecom commented 4 months ago

I think it's better to remove the dependency constraint

dorianmariecom commented 4 months ago

Makes my app able to upgrade to rails 8 in conjonction with https://github.com/fractaledmind/solid_errors/pull/49

dorianmariecom commented 3 months ago

thx @dhh

dorianmariecom commented 3 months ago

@dhh could you release a new version for this?

rosa commented 3 months ago

Oh, @dorianmariecom, I think this is wrong, because it'd allow you to run Mission Control with rails < 7.1. What was the problem with that? rails >= 7.1 allows you to use Rails 8. We run this with Rails 8.

rosa commented 3 months ago

https://github.com/rails/mission_control-jobs/pull/120 was precisely to allow running Rails 8. I'm going to revert this change.

dorianmariecom commented 3 months ago

Yeah that's weird, I thought >= 7.1 wasn't working for me, maybe a transitive issue with rails main versions

dorianmariecom commented 3 months ago

I still thinks it's better to remove the dependency constraint