search

rails / mission_control-jobs

Dashboard and Active Job extensions to operate and troubleshoot background jobs
MIT License
611 stars 71 forks source link

Redirect back after discarding a job #157

Closed thiagobc closed 3 weeks ago

thiagobc commented 2 months ago

Discarding a job can currently be done from "Failed jobs" and "Scheduled jobs" pages, but, as a result, the user is always redirected to "Failed jobs" page.

This change will make the user be redirected back instead.

rosa commented 3 weeks ago

Thank you @thiagobc, and sorry for the delay! I'be been busy with other stuff and haven't had time to look at this gem, but I'm catching up now.

rosa commented 3 weeks ago

Ahh, this breaks the case of discarding a job from its individual page. It'd try to redirect to the job page, but it'll get a 404 error because the job is gone. I'll fix it.

thiagobc commented 3 weeks ago

Hi @rosa! Sorry for breaking the pipeline, I missed running bin/rails app:test:system before creating the PR. 🤦

Anyway, thanks to you for the great project and for fixing my changes 🙏. (that was a smart fix by the way.)

rosa commented 3 weeks ago

Oh, no worries at all, not your fault! I'm not sure why the tests didn't run automatically as part of your PR... they should have! You shouldn't need to remember that. Thanks a lot for your fix and your kind words!