search

rails / mission_control-jobs

Dashboard and Active Job extensions to operate and troubleshoot background jobs
MIT License
610 stars 71 forks source link

error ActionController::UrlGenerationError in MissionControl::Jobs::Jobs#index for some tabs #167

Closed francescob closed 1 week ago

francescob commented 1 month ago

Some of the tabs work correctly, but others give a routing error when clicked. Failing tabs are

the error is:

`Showing /home/francesco/.asdf/installs/ruby/3.3.5/lib64/ruby/gems/3.3.0/gems/mission_control-jobs-0.3.1/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb where line #3 raised:

No route matches {:page=>1} `

using on a rails 7.2.1 app with mission_control-jobs (0.3.1) and solid_queue (1.0.0)

rosa commented 1 week ago

Hey @francescob, this is quite strange! I wonder if it might have been related to https://github.com/rails/mission_control-jobs/issues/183.

francescob commented 1 week ago

Hi, thanks for the heads up! it's not related to that, but however i've found the culprit, we had this def url_options(options = {}) options.merge(locale: I18n.locale, only_path: true) end

which i don't even know why was there, a coworker copied it in a new app from an old one, and commenting it (which apparently was doing nothing except breaking stuff like your gem) the links of mission_control-jobs now work correctly.

rosa commented 1 week ago

Ohhh! Thanks a lot for letting me know! That's a new one, I hadn't seen this before 😅 Glad you could figure it out.