search

rails / mission_control-jobs

Dashboard and Active Job extensions to operate and troubleshoot background jobs
MIT License
611 stars 71 forks source link

Add simple HTTP authentication that can be used via configuration or ENV #171

Open krtschmr opened 1 month ago

krtschmr commented 1 month ago

We needed a very simple easy way to add http_auth. inheriting from own controller seems overkill.

fixes #166

image

rosa commented 3 weeks ago

@krtschmr thanks for this! We need to have some default authentication built-in before we can propose this as default for Rails, but I'm not sure yet how it's going to look, so I'll keep this PR on hold until then.

krtschmr commented 3 weeks ago

Hi @rosa i'm unsure what you mean with DefaultAuthentication. Doesn't this act like it somehow? right now everybody needs to implement their own logic, this would be a very quick way to at least have it protected from the start. (we use it in production already)

rosa commented 3 weeks ago

@krtschmr, I mean some authentication solution that comes enabled by default, so yes, this would work, but I'm not sure if we'll go with basic auth or with something else (such as a simple cookie-based authentication). It also needs to be closed by default in production and be easy to configure. I haven't decided yet what it'll look like.