rails / mission_control-jobs

Dashboard and Active Job extensions to operate and troubleshoot background jobs
MIT License
611 stars 71 forks source link

Adds note to README.md regarding CSS bundling issues on vendored libs #208

Closed junket closed 2 days ago

junket commented 2 days ago

From version 0.5.0 to 0.6.0, bulma.min.css was vendored into the lib instead of linking to the CDN version to better conform to the content security policy.

Unfortunately, when passing through a common older CSS bundler (sass-rails) during rails assets:precompile, that CSS doesn't seem to pass muster:

SassC::SyntaxError: Error: Invalid CSS after "...--s),var(--l));": expected "}", was "--00-l:var(--bulma-" (SassC::SyntaxError)

I assume Bulma is using some feature of DartSass/CSS that sass-rails and sassc-rails do not support. Updating the CSS bundler to dartsass-rails fixes the issue.

rosa commented 2 days ago

Ohh, great catch, explanation and change! Thank you so much!