rails / mission_control-jobs

Dashboard and Active Job extensions to operate and troubleshoot background jobs
MIT License
517 stars 56 forks source link

Allow filtering workers by hostname, name or even by configuration/queues #29

Open rosa opened 7 months ago

rosa commented 7 months ago

Right now we don't have any filters for workers. With a few hundreds of workers, finding the ones you want becomes a bit tricky, and more so if we add #28. It'd be nice to filter them just like we filter jobs.

jaredholdcroft commented 7 months ago

I'd like to work on this issue.

Xeitor commented 6 months ago

hi, is anyone currently working on this? if not, I would like to give it a try :)

jaredholdcroft commented 6 months ago

Still me! I was waiting for https://github.com/basecamp/mission_control-jobs/issues/28 and then got busy. Hoping to have a PR done this weekend.

Xeitor commented 6 months ago

sure no problem

matiassalles99 commented 5 months ago

hey! anyone currently working on this issue? Looks like a good one to get started on this project and I would love to give it a try

jaredholdcroft commented 5 months ago

I've unassigned myself, life got in the way of this unfortunately.

matiassalles99 commented 5 months ago

🙁 sorry to hear that. I can take a look at it throughout this week, I should have something ready to review by Sat/Sun

Xeitor commented 5 months ago

hi @matiassalles99, I took de liberty to open a PR draft since I did some work with jobs filters and this was pretty similar

matiassalles99 commented 5 months ago

@Xeitor sg, I added name and hostname filters a couple of days ago but didn't open a PR - feel free to grab any changes from my branch if they come in handy (https://github.com/rails/mission_control-jobs/compare/main...matiassalles99:mission_control-jobs:worker-filters?expand=1)

Xeitor commented 5 months ago

ohh sorry @matiassalles99, you can go ahead and submit yours

matiassalles99 commented 5 months ago

@Xeitor nah it's fine don't worry, I can take a look at another issue 💪