rails / propshaft

Deliver assets for Rails
MIT License
864 stars 93 forks source link

Add support for digest_class config #155

Closed aduth closed 10 months ago

aduth commented 11 months ago

This pull request proposes to add support for a digest_class configuration, to override the behavior of asset digesting.

Why?

Open Questions:

brenogazzola commented 10 months ago

@aduth Thank you for the PR, however one of the reasons we've built this gem was to have a clean slate to work on compared to Sprockets. This means that feature parity with Sprockets is the opposite of what we want. We can revisit this at a later date, whoever as long was Sprockets is supported, features that are not core to Propshaft (full support for no build, better support for builders) are not our focus.

aduth commented 10 months ago

@brenogazzola Totally fair on the point of feature parity with Sprockets.

My interest was more in shortening the current digest length, and feature parity was a convenient approach to achieving this. I added some alternative approaches in the original comment; would there be any more of an appetite for these?

If there's not an interest in adding this configuration, would there be more reception to either (a) allowing the digest length to be configuration, or (b) changing the default to a shorter length?

Happy to create an issue if that's the best path forward for discussing.