search

rails / protected_attributes

Protect attributes from mass-assignment in ActiveRecord models.
MIT License
228 stars 92 forks source link

closes #55 #56

Closed andrewpcone closed 9 years ago

jGRUBBS commented 9 years ago

based on the build results from travis CI this looks to be breaking in rails 4.1 and 4.2

andrewpcone commented 9 years ago

It appears that rails recently changed its interface, and Travis CI is pulling latest

https://github.com/rails/rails/commit/ecdae459d209ae5144fd4390e8a6f247d7f98a1c#diff-4e9083413ec4b38982bb9e737f7454e8

So this build failure happens regardless of my patch. If you have an opinion about how to address this issue, I'm happy to work on it.

It looks like the rails file activerecord/lib/active_record/associations/through_association.rb needs to be patched to take an options hash. Do you agree?

jGRUBBS commented 9 years ago

Ah I think your tests are broken by the same issue I corrected here: #54 So when those get merged in, your PR should pass all tests.