[FIX] TooManyRecords exception is defined in NestedAttributes not MasAssignmentSecurity

rails / protected_attributes

Protect attributes from mass-assignment in ActiveRecord models.

MIT License

228 stars 92 forks source link

[FIX] TooManyRecords exception is defined in NestedAttributes not MasAssignmentSecurity #74

Closed AvnerCohen closed 8 years ago

AvnerCohen commented 9 years ago

When this cdoe path is hit, I am getting: uninitialized constant ActiveRecord::MassAssignmentSecurity::NestedAttributes::TooManyRecords

This is because TooManyRecords is actually defined in ActiveRecord::MassAssignmentSecurity::TooManyRecords

Now, I'm quite there is a more clever way to get to it on the class hierarchy, without spelling out the absolute hierarchy, but I haven't found it in a quick search. :(

roshiro commented 8 years ago

Hi @AvnerCohen, the fix for that issue has already been made and merged here

AvnerCohen commented 8 years ago

How weird is it to have the other PR taken, nearly a year after mine this one was sent and was totally ignored for over a year.. /cc @rafaelfranca

As I would like to understand for the future how to better contribute, would love to understand what was the reason for that.

rafaelfranca commented 8 years ago

Sorry about that. The only explanation I have is that I didn't saw your PR (it is true) and there is nothing you did wrongly. It was my fault, really sorry.