search

rails / protected_attributes

Protect attributes from mass-assignment in ActiveRecord models.
MIT License
228 stars 92 forks source link

Avoid double callbacks in Rails >= 4.1 #81

Closed pacoguzman closed 8 years ago

pacoguzman commented 8 years ago

This PR provides the same solution like https://github.com/rails/protected_attributes/pull/78 but I've added a test.

I wasn't able to use any person model combination to reproduce the problem that's why I've added the NestedBattle model

rails-bot commented 8 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

arthurnn commented 8 years ago

Thanks

westonganger commented 8 years ago

Do you think you could release version 1.1.4 with this fix?