rails / protected_attributes

Protect attributes from mass-assignment in ActiveRecord models.
MIT License
228 stars 92 forks source link

Fixes the Activerecord::TooManyRecords namespace: #85

Closed Edouard-chin closed 8 years ago

Edouard-chin commented 8 years ago

Not too sure if I should add a test for this.

Thanks :)

rails-bot commented 8 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rafaelfranca commented 8 years ago

Thanks! A test would be useful, yes. Not sure how hard it is though. Could you give it a try?

Edouard-chin commented 8 years ago

Sure! I made the change, but no rush, review whenever you have time ;). Good night

thedrow commented 8 years ago

Is this released already?

rafaelfranca commented 8 years ago

Not yet.