Closed Edouard-chin closed 8 years ago
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
Thanks! A test would be useful, yes. Not sure how hard it is though. Could you give it a try?
Sure! I made the change, but no rush, review whenever you have time ;). Good night
Is this released already?
Not yet.
TooManyRecords
was in theActiveRecord::MassAssignmentSecurity::NestedAttributes
namespace, resulting in aUnitializedConstant
exceptionNot too sure if I should add a test for this.
Thanks :)