search

rails / protected_attributes

Protect attributes from mass-assignment in ActiveRecord models.
MIT License
228 stars 92 forks source link

Bugfixes in master are not yet released #91

Closed mru2 closed 7 years ago

mru2 commented 7 years ago

Hi,

We are in the process of migrating our app from Rails 4.0 to Rails 4.1

We encountered the #77 issue, which was fixed in master by the #81 PR

We could require the master branch, but we would rather depend on a stable gem version.

Are you planning to release a new version of the gem soon ?

Thanks!

westonganger commented 7 years ago

Use my maintained gem protected_attributes_continued https://github.com/westonganger/protected_attributes_continued

rafaelfranca commented 7 years ago

@westonganger do you understand that you might be doing a disservice for the community? This gem doesn't support Rails 5 for a really good reason, that is to improve security of the applications. Maintaining it for Rails 5 in my opinion will hurt more than help.

westonganger commented 7 years ago

I understand it shouldnt be used if it doesnt have to. But some legacy apps simply do not care to update this portion of their code but still want to have support for Rails 5+.

rafaelfranca commented 7 years ago

But some legacy apps simply do not care to update this portion of their code

They really should. Since this code is MIT there is nothing I can do about your forking and adding support, but please don't come to the issue tracker recommend people to use it, even more in an issue that is not related to it.

rafaelfranca commented 7 years ago

1.1.4 was released.