search

rails / rails-bot

Github hooks to provide an encouraging atmosphere for new contributors
13 stars 11 forks source link

Automatic close pull requests to reflection files #3

Open rafaelfranca opened 9 years ago

rafaelfranca commented 9 years ago

Even with the comment on top of the file people still send PRs changing inflectors. We can detect it and warn or even automatically close all PRs that touches this file.

Thoughts @sgrif @fxn @matthewd

sgrif commented 9 years ago

Seems reasonable. We can probably have the automated message give 100% of the context needed.

fxn commented 9 years ago

:+1:

matthewd commented 9 years ago

Does this come up enough to bother? My recollection is that most of the inflection reports we see are issues, not PRs.

rafaelfranca commented 9 years ago

I see at least one per month. I thought that given we have a way to automatize the feedback we could use it, but we can keep doing it manually too.