search

rails / rails

Ruby on Rails
https://rubyonrails.org
MIT License
55.87k stars 21.63k forks source link

Public storage tests are not ran in CI #39015

Open peterzhu2118 opened 4 years ago

peterzhu2118 commented 4 years ago

Steps to reproduce

Credentials for public buckets are not supplied on CI on master so public service tests are not ran (feature was implemented in #36729).

Expected behavior

Tests are ran on CI on master.

Actual behavior

Skipping Azure Storage Public Service tests because no Azure configuration was supplied

Skipping GCS Public Service tests because no GCS configuration was supplied

Skipping S3 Public Service tests because no S3 configuration was supplied

Are present in the logs for Active Storage tests.

System configuration

Rails version: master

Ruby version: all

rails-bot[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not been commented on for at least three months. The resources of the Rails team are limited, and so we are asking for your help. If you can still reproduce this error on the 6-0-stable branch or on master, please reply with all of the information you have about it in order to keep the issue open. Thank you for all your contributions.

peterzhu2118 commented 4 years ago

The tests are still not ran on CI.

lfalcao commented 3 years ago

Still not being tested. Can I help with it?

ghiculescu commented 3 years ago

https://github.com/rails/rails/pull/30252 suggests that https://github.com/rails/rails/blob/main/activestorage/test/service/configurations.yml.enc needs to be edited, and @dhh has the keys.