rails / sass-rails

Ruby on Rails stylesheet engine for Sass
MIT License
860 stars 333 forks source link

Bump the rails test dependencies. #380

Closed voxik closed 8 years ago

voxik commented 8 years ago

The test applications should be able to run with RoR according to my testing.

rails-bot commented 8 years ago

r? @rafaelfranca

(@rails-bot has picked a reviewer for you, use r? to override)

voxik commented 8 years ago

And this would be useful also to 5-0-stable branch ...

robin850 commented 8 years ago

Hey @voxik,

Thanks for the patch ! Actually the tests aren't passing with 5.0 or current master, could you please touch the following files:

with the following content:

//= link_tree ../images
//= link_directory ../javascripts .js
//= link_directory ../stylesheets .css

And also git apply the following patch:

--- a/test/fixtures/engine_project/engine_project.gemspec
+++ b/test/fixtures/engine_project/engine_project.gemspec
@@ -7,11 +7,10 @@ require "engine_project/version"
 Gem::Specification.new do |s|
   s.name        = "engine_project"
   s.version     = EngineProject::VERSION
-  s.authors     = ["TODO: Your name"]
-  s.email       = ["TODO: Your email"]
-  s.homepage    = "TODO"
-  s.summary     = "TODO: Summary of EngineProject."
-  s.description = "TODO: Description of EngineProject."
+  s.authors     = ["wycats", "chriseppstein"]
+  s.email       = ["wycats@gmail.com", "chris@eppsteins.net"]
+  s.summary     = "Summary of EngineProject."
+  s.description = "Description of EngineProject."

   s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.rdoc"]
   s.test_files = Dir["test/**/*"]

Then we can certainly merge this one. :-)

voxik commented 8 years ago

Actually, there was already applied acff4b407f7a74ae562 to the master and several others, which should improve the rails 5 compatibility, so I am closing this one.