Closed junaruga closed 7 years ago
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.
thanks
I updated Rubies to latest version. I also added ruby-head to Travis as allow_failures.
I think this is useful. Because we can prepare before next version Ruby 2.5 release.
We can see this kind of logic in
rails/rails
,rspec
andcucumber
and etc.https://github.com/rails/rails/blob/master/.travis.yml https://github.com/rspec/rspec-core/blob/master/.travis.yml https://github.com/cucumber/cucumber-ruby/blob/master/.travis.yml
Is it possible to merge?
Thanks.