rails / sass-rails

Ruby on Rails stylesheet engine for Sass
MIT License
859 stars 333 forks source link

include ERB before Deprecated #407

Closed richpeck closed 5 years ago

richpeck commented 7 years ago

If you include Deprecated before include ERB, you're unable to import [css/scss/sass].erb files through globbing. Importing [css/scss/sass].erb files directly seems to work fine:

untitled

untitled

rails-bot commented 7 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rails-bot commented 7 years ago

warning Warning warning

schneems commented 7 years ago

There are some failures on travis:

SassRailsTest#test_sass_defines_compressor_by_default_in_test_mode [/home/travis/build/rails/sass-rails/test/sass_rails_test.rb:75]:
--- expected
+++ actual
@@ -1 +1,15 @@
-"sass"
+"DEPRECATION WARNING: Leaving `ActiveRecord::ConnectionAdapters::SQLite3Adapter.represent_boolean_as_integer`
+set to false is deprecated. SQLite databases have used 't' and 'f' to serialize
+boolean values and must have old data converted to 1 and 0 (its native boolean
+serialization) before setting this flag to true. Conversion can be accomplished
+by setting up a rake task which runs
+
+  ExampleModel.where(\"boolean_column = 't'\").update_all(boolean_column: 1)
+  ExampleModel.where(\"boolean_column = 'f'\").update_all(boolean_column: 0)
+
+for all models and all boolean columns, after which the flag must be set to
+true by adding the following to your application.rb file:
+
+  Rails.application.config.active_record.sqlite3.represent_boolean_as_integer = true
+ (called from <top (required)> at /tmp/d20170728-23584-czknlz/config/environment.rb:5)
+sass"
bin/rails test home/travis/build/rails/sass-rails/test/sass_rails_test.rb:69