search

rails / sass-rails

Ruby on Rails stylesheet engine for Sass
MIT License
859 stars 333 forks source link

update sass gem #415

Closed samdemaeyer closed 6 years ago

samdemaeyer commented 6 years ago

I can't export the SCSS file in scss/bootstrap.scss, it says:

Error: Invalid CSS after "...lor}: #{$value}": expected "{", was ";"
on line 4 of C:/bootstrap-4.0.0-beta.2/scss/_root.scss
from line 11 of C:\bootstrap-4.0.0-beta.2\scss\bootstrap.scss
Use --trace for backtrace.
[Finished in 1.0s]

This error is introduced by the sass gem. this is resolved in v3.5.2+.

rails-bot commented 6 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

jeromedalbert commented 6 years ago

I have the same error with the bootstrap final 4.0 from source. It would be nice to have this PR merged.

rafaelfranca commented 6 years ago

Thank you for the pull request but there is no reason we need to enforce that version. 3.5.2+ is allowed with the current code.

jeromedalbert commented 6 years ago

Right, the tilde pessimistic operator would indeed support sass 3.5.2+. In my case, the sass gem would not update because of a version dependency from an old version of the scss_lint gem, not sass-rails. Updading scss_lint unblocked my sass version. 👍