rails / sass-rails

Ruby on Rails stylesheet engine for Sass
MIT License
859 stars 333 forks source link

Ruby Sass End-of-Life: 26 March 2019 #420

Closed chriseppstein closed 5 years ago

chriseppstein commented 6 years ago

This was announced about a month ago, but I wanted to make sure the Rails community is aware that the Ruby implementation of Sass has been EOL'd.

TL;DR:

That is, unless, there's at least one new, active maintainer for the ruby implementation of Sass. Preferably more than one.

Rails needs a plan a plan to deal with this before the ruby version becomes unmaintained. If a first-class Sass implementation for the ruby and rails community is desired, hopefully a maintainer can be found. Otherwise, one of the other Sass implementations can be used (most likely through node/npm).

EugenMayer commented 6 years ago

any progress here?

NARKOZ commented 6 years ago

SassC requires CRuby

jrochkind commented 5 years ago

Generating a new default Rails 5.2 app gets you this deprecation warning.

March 2019 is coming up, is there any news on what is expected?

coorasse commented 5 years ago

I personally started switching to Webpacker. Migration of existing apps it is pretty easy and it will be the default Javascript compiler in Rails 6. Migrating CSS is even easier than migrating JS. I leave here a guide to do that. I hope it will help someone else.

Fudoshiki commented 5 years ago

@coorasse I need simple css file for each page, not bundle, Sprockets do that easy, with Webpack this is no trivial task Not for all sites need react and not all sites are SPA

amalrik commented 5 years ago

Maybe sassc-rails should be used as a drop-in replacement for sass-rails? I have the impression it should be pretty easy to change that on rails generators.

amalrik commented 5 years ago

Ok now I see the thread on rails main repo and it seems its not possible to simple replace sass-rails with sassc-rails. So migrate to webpacker seems to be the way to go.

jrochkind commented 5 years ago

@amalrik can you link to the thread on rails main repo for us?

In my specific apps, I have switched to sassc-rails without problem. Although I have no trouble believing there are reasons it can't work universally. I am curious to see what is being discussed on rails repo.

amalrik commented 5 years ago

@jrochkind https://github.com/rails/rails/issues/32896

jakeonfire commented 5 years ago

@amalrik the tables have turned again in favor of sassc-rails: https://github.com/rails/sass-rails/issues/420 [edit: or at least there is still debate and desire to avoid forcing everyone to use Webpacker]

thomasbalsloev commented 5 years ago

@amalrik

They are still contemplating simply replacing the sass processor with the sassc processor in sass-rails it seems: https://github.com/rails/rails/pull/34884#issuecomment-456919750

amalrik commented 5 years ago

thanks @P9GIT I will take a look if I can contribute to that in some way.

guilleiguaran commented 5 years ago

See https://github.com/rails/sass-rails/pull/424

thomasbalsloev commented 5 years ago

@guilleiguaran

Awesome! Thanks!