search

rails / sass-rails

Ruby on Rails stylesheet engine for Sass
MIT License
859 stars 333 forks source link

Update travis test matrix #421

Closed gssbzn closed 5 years ago

gssbzn commented 5 years ago

Drop support for EOL version of ruby and add support for 2.5 Add support for rails 5.2

rails-bot commented 5 years ago

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

gssbzn commented 5 years ago

All test should be passing now, that took more effort than I was expecting, all warnings should be gone from travis as well taking some of the changes from #413

For some reason I had to disable the cache of bundler or travis would error with missing gem errors, if someone has a better idea on how to solve that let me know