search

rails / solid_cable

A database backed ActionCable adapter
MIT License
204 stars 14 forks source link

support nil logger #39

Closed navidemad closed 1 month ago

navidemad commented 1 month ago

This feature has been implemented in solid_queue gem (https://github.com/rails/solid_queue/pull/175) I replicated the implementation for this gem. FIxes rails/solid_cable/issues/38

navidemad commented 1 month ago

@npezza93 To better reflect the intent of asserting that no exceptions are raised, I changed the test name to indicate that we are specifically testing for the absence of errors when there's no Active Record logger. Also, I ensure that the message is successfully broadcast to the queue. This approach ensures that the test covers the intended behavior without diving into private methods and focuses on preventing exceptions.