search

rails / solid_queue

Database-backed Active Job backend
MIT License
1.66k stars 90 forks source link

Generalize `silence_polling` to `silence_queries` #210

Open namolnad opened 3 months ago

namolnad commented 3 months ago 
          Yes, I think `silence_queries` would work 👍🏻

_Originally posted by @rosa in https://github.com/rails/solid_queue/issues/198#issuecomment-2048122748_

As mentioned in #198, silence_polling only silences the polling queries (which makes sense), and continues to log for all other querying methods. I think many, especially in a development environment, would be interested in a silence_queries setting to fully silence heart_beat, semaphore, etc queries and keep their logs clean. We likely should maintain silence_polling, at least for now, for backwards compatibility.

namolnad commented 3 months ago

@rosa do you know of a global way we can wrap all the querying methods in solid_queue in a similar fashion to how the polling is wrapped currently? Or is it more likely that we'll just need to pick off the methods one-by-one and make sure new functionality gets wrapped similarly? Happy to take a stab at this one once that approach gets nailed down. Thanks!