rails / solid_queue

Database-backed Active Job backend
MIT License
1.84k stars 110 forks source link

Handle case of concurrency limit not being set in Semaphore #221

Closed rosa closed 5 months ago

rosa commented 5 months ago

Avoid crashing in this case, just assume concurrency limit is 1. This shouldn't happen with normal operation but we've had this problem when jobs that are concurrency-limited are enqueued from new code and dispatched from old code, where the job still doesn't have concurrency controls, thus returning nil for the limit and crashing the dispatcher.