Avoid three-state boolean (TRUE / FALSE / NULL) for `solid_queue_recurring_tasks` `static`

rails / solid_queue

Database-backed Active Job backend

MIT License

1.84k stars 110 forks source link

Avoid three-state boolean (TRUE / FALSE / NULL) for `solid_queue_recurring_tasks` `static` #283

Closed ksylvest closed 1 month ago

ksylvest commented 1 month ago

This ensures the recurring tasks static is always either TRUE or FALSE (never NULL).

ksylvest commented 1 month ago

A bit unclear on the failure for this:

/home/runner/work/solid_queue/solid_queue/vendor/bundle/ruby/3.2.0/gems/puma-6.4.2/lib/puma/binder.rb:334:in `initialize': Address already in use - bind(2) for "127.0.0.1" port 9222 (Errno::EADDRINUSE)

This might be selenium re-using the port for some reason?

rosa commented 1 month ago

I retried these tests and they worked just fine. I'm going to remove the puma plugin soon anyway, so that test will go away in any case. I've never hit this one locally, though!