Fix memoization for `#recurring_tasks_config`

rails / solid_queue

Database-backed Active Job backend

MIT License

1.95k stars 130 forks source link

Fix memoization for `#recurring_tasks_config` #361

Closed sergiopantoja closed 1 month ago

sergiopantoja commented 1 month ago

First, thanks for all of your work on this gem! I love watching the progress.

I was reviewing the recurrence implementation and noticed the memoized instance variable name was shared for both #recurring_tasks and #recurring_tasks_config. This appears to have been introduced in 0aa1644e38dd8c8cfcaf6d0ce3cd9e22ebd1a90b.

This isn't causing any bugs for me currently, but I figured this PR would help prevent any potential issues in the future.

rosa commented 1 month ago

Ohh, totally! Great spot, this was a mistake from copying and pasting 😅