search

rails / solid_queue

Database-backed Active Job backend
MIT License
1.95k stars 130 forks source link

Use Current Migration Version #370

Closed robertomiranda closed 1 month ago

robertomiranda commented 1 month ago

Hola 👋

I've noticed that when installing Solid Queue in Rails projects (version 7.1 and above), the generator continues to use the older version for the queue schema, 7.1. I'm curious if this is intentional and whether aligning it with the current project version might be more appropriate. As of now, Rails versions 7.1, 7.2, and 8.0 don't seem to have any compatibility issues, so this hasn't caused problems.

https://github.com/rails/rails/blob/4f68f3e1e6c2eaad8256100dad51d308e7e67046/activerecord/lib/active_record/migration/compatibility.rb#L32-L38

However, for future Rails releases, it might be beneficial for the generator to track and use the version in use.

Gracias 🙇

dhh commented 1 month ago

Older schema versions will always be supported. The versioning is there in case the syntax changes. So all is good as-is.