rails / solid_queue

Database-backed Active Job backend
MIT License
1.95k stars 130 forks source link

Add compatibility with strict_loading_by_default #375

Open JoeDupuis opened 1 month ago

JoeDupuis commented 1 month ago

Fixes #122

Allows the app to run in strict_loading_by_default mode by explicitly turning off strict loading on all Solid Queue models.

Also enables strict_loading_by_default on the dummy app to prevent strict loading issues from being introduced.

Alternative / strict_loading enabled

I tried to support strict_loading instead of turning it off, but after spending time on it, I don't think it's worth it. It is a little bit faster, but bring a bunch of complexity. I opened a draft PR on my fork to demonstrate what it would look like: https://github.com/JoeDupuis/solid_queue/pull/1 Even if we decide to go down the road of enabling strict_loading in Solid Queue, we should merge this PR first to unblock strict_loading apps while working on the fix.